Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Notifier to check the DMesg Logs for OOPS Exceptions #3617

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

umfranci
Copy link
Collaborator

At the moment when a test case is executed, the Pass/Fail status is specific to the tasks executed as part of the test but the OOPS exceptions are not checked. Hence creating a notifier that can run a regex pattern against the DMesg logs and capture the contextual log lines around the found OOPS.

These findings will then be saved in the artifacts generated against the tests which can further be utilized for creating any kind of notifications/alerts.

@umfranci umfranci changed the title Umfranci/dmesg notifier 21012025 1 New Notifier to check the DMesg Logs for OOPS Exceptions Jan 27, 2025
@squirrelsc
Copy link
Member

The notifier isn't a right place for panic checks, and the dmesg tool handles more scenarios. The notifier cannot fail the test case, so the results is hard to associate with the failed cause.

  1. If the purpose wants to capture kernel panic or call trace in some test cases, you can always call Dmesg.check_kernel_errors in the test case.
  2. If it wants to capture errors in general, you can check what LISA have now, and may apply an extra check switch, so any kernel error happens, fail the just ran test case and mark the env bad.

@umfranci
Copy link
Collaborator Author

The notifier isn't a right place for panic checks, and the dmesg tool handles more scenarios. The notifier cannot fail the test case, so the results is hard to associate with the failed cause.

  1. If the purpose wants to capture kernel panic or call trace in some test cases, you can always call Dmesg.check_kernel_errors in the test case.
  2. If it wants to capture errors in general, you can check what LISA have now, and may apply an extra check switch, so any kernel error happens, fail the just ran test case and mark the env bad.

@squirrelsc Thanks for the comment. The purpose of the Notifier is not to fail the test cases in case of an OOPS/Kernel Error but to simply save the detections in a file, which can then be later utilized for notification purposes. There are many tests which do not check the Dmesg logs for issues since the purpose of the test case might not necessarily need it - though it was still important to check Dmesg logs for each of the tests without actually failing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants